From 3dabba57df7a63da41cbf6e0e49b01fc22dd3bfa Mon Sep 17 00:00:00 2001 From: "Bruce, Matt R" Date: Mon, 21 Mar 2022 13:13:40 +0000 Subject: [PATCH] Fixed Crash on securetext in TextEntryField --- .../Atomic/Atoms/FormFields/TextFields/DigitEntryField.swift | 4 ++++ .../Atomic/Atoms/FormFields/TextFields/TextEntryField.swift | 5 ++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/DigitEntryField.swift b/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/DigitEntryField.swift index a0de9d1f..2e098ad9 100644 --- a/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/DigitEntryField.swift +++ b/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/DigitEntryField.swift @@ -249,6 +249,10 @@ import UIKit //-------------------------------------------------- // MARK: - Methods //-------------------------------------------------- + public override func showErrorView(_ show: Bool) { + //do nothing since you should show the error view + //within a digitEntryField + } @objc public func setAsSecureTextEntry(_ secureEntry: Bool) { diff --git a/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/TextEntryField.swift b/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/TextEntryField.swift index 89e17169..d081b717 100644 --- a/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/TextEntryField.swift +++ b/MVMCoreUI/Atomic/Atoms/FormFields/TextFields/TextEntryField.swift @@ -84,7 +84,7 @@ import UIKit textField.accessibilityValue = nil } - if textField.isSecureTextEntry { + if !textField.isSecureTextEntry { showErrorView(error) } @@ -294,8 +294,7 @@ import UIKit resignFirstResponder() } - private func showErrorView(_ show: Bool) { - + open func showErrorView(_ show: Bool) { if show { entryFieldContainer.addSubview(errorImage)