mbrucedogs/mvm_core_ui
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Accessibility label changes for heart.

Browse Source
This commit is contained in:
Lekshmi S 2020-10-06 16:13:02 +05:30
parent d43cf7dfa0
commit 1bf75c9929
5 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
MVMCoreUI/Atomic/Atoms/Selectors/Heart.swift
View File

@ -79,7 +79,6 @@ import UIKit
heightConstraint = heightAnchor.constraint(equalTo: widthAnchor, multiplier: 1)
heightConstraint?.isActive = true
isAccessibilityElement = true
accessibilityHint = MVMCoreUIUtility.hardcodedString(withKey: "heart_action_hint")
accessibilityTraits = .button
updateAccessibilityLabel()
}
@ -97,10 +96,8 @@ import UIKit
//--------------------------------------------------
/// Adjust accessibility label based on selection of Heart.
func updateAccessibilityLabel() {
if let message = MVMCoreUIUtility.hardcodedString(withKey: "heart"),
let selectedState = MVMCoreUIUtility.hardcodedString(withKey: isSelected ? "heart_selected_state" : "heart_not_selected_state") {
accessibilityLabel = message + selectedState
}
accessibilityHint = MVMCoreUIUtility.hardcodedString(withKey: isSelected ? "heart_unfavorite_action_hint" : "heart_favorite_action_hint")
accessibilityLabel = MVMCoreUIUtility.hardcodedString(withKey: isSelected ? "heart_selected_state" : "heart_not_selected_state")
}
func tapAction() {

2
MVMCoreUI/Atomic/Atoms/Selectors/HeartModel.swift
View File

@ -60,6 +60,6 @@ open class HeartModel: MoleculeModelProtocol {
try container.encode(isActive, forKey: .isActive)
try container.encode(activeColor, forKey: .activeColor)
try container.encode(inActiveColor, forKey: .inActiveColor)
try container.encodeModelIfPresent(action, forKey: .action)
try container.encodeModel(action, forKey: .action)
}
}

4
MVMCoreUI/SupportingFiles/Strings/en.lproj/Localizable.strings
View File

@ -68,8 +68,8 @@
"AccToggleHint" = "double tap to toggle";
// MARK: Heart
"heart" = "Favorite";
"heart_action_hint" = "Double tap to favorite";
"heart_favorite_action_hint" = "Double tap to favorite";
"heart_unfavorite_action_hint" = "Double tap to unfavorite";
"heart_selected_state" = "Favorited";
"heart_not_selected_state" = "Unfavorited";

3
MVMCoreUI/SupportingFiles/Strings/es-MX.lproj/Localizable.strings
View File

@ -50,7 +50,8 @@
"AccOff" = "apagado";
"AccToggleHint" = "toca dos veces para alternar";
// Heart
"heart_action_hint" = "Toca dos veces en favorito";
"heart_favorite_action_hint" = "Toca dos veces en favorito";
"heart_unfavorite_action_hint" = "Toca dos veces para dejar de marcar como favorito";
"heart_selected_state" = "Favoritos";
"heart_not_selected_state" = "No favorito";
// Carousel

3
MVMCoreUI/SupportingFiles/Strings/es.lproj/Localizable.strings
View File

@ -53,7 +53,8 @@
"AccToggleHint" = "toca dos veces para alternar";
// Heart
"heart_action_hint" = "Toca dos veces en favorito";
"heart_favorite_action_hint" = "Toca dos veces en favorito";
"heart_unfavorite_action_hint" = "Toca dos veces para dejar de marcar como favorito";
"heart_selected_state" = "Favoritos";
"heart_not_selected_state" = "No favorito";