From a5f5ed3cd16196b3f069b859e3efb938e932f883 Mon Sep 17 00:00:00 2001 From: Kyle Matthew Hedden Date: Tue, 5 Jul 2022 18:03:13 -0400 Subject: [PATCH 1/2] Update session keep alive to account for all new session tokens outside of BAU server session. --- MVMCore/MVMCore/LoadHandling/MVMCoreLoadObject.m | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/MVMCore/MVMCore/LoadHandling/MVMCoreLoadObject.m b/MVMCore/MVMCore/LoadHandling/MVMCoreLoadObject.m index 7a52182..9c56d99 100644 --- a/MVMCore/MVMCore/LoadHandling/MVMCoreLoadObject.m +++ b/MVMCore/MVMCore/LoadHandling/MVMCoreLoadObject.m @@ -61,8 +61,11 @@ } - (BOOL)extendsAppSession { - NSNumber *extendSessionFlag = [self.responseInfoMap optionalNumberForKey:@"appSessionExtended"]; - return extendSessionFlag == nil || [extendSessionFlag boolValue]; // Default to YES if the key does not exist. + //NSNumber *extendSessionFlag = [self.responseInfoMap optionalNumberForKey:@"appSessionExtended"]; + //return extendSessionFlag == nil || [extendSessionFlag boolValue]; // Default to YES if the key does not exist. + + // With the introduciton of NSA and OIDC tokens, we can no longer rely on BAU network touches to update our server session. + return NO; } #pragma mark - Deprecated From ded68fe51f5f2bd8ad59dfba002b571fd9a40e1f Mon Sep 17 00:00:00 2001 From: Kyle Matthew Hedden Date: Wed, 13 Jul 2022 23:31:43 -0400 Subject: [PATCH 2/2] reduce cookie noise --- MVMCore/MVMCore/LoadHandling/MVMCoreLoadHandler.m | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MVMCore/MVMCore/LoadHandling/MVMCoreLoadHandler.m b/MVMCore/MVMCore/LoadHandling/MVMCoreLoadHandler.m index 27043bf..3985236 100644 --- a/MVMCore/MVMCore/LoadHandling/MVMCoreLoadHandler.m +++ b/MVMCore/MVMCore/LoadHandling/MVMCoreLoadHandler.m @@ -311,8 +311,8 @@ } MVMCoreLog(@"********************************* Cookie Sent *********************************"); - [[[NSHTTPCookieStorage sharedHTTPCookieStorage] cookies] enumerateObjectsUsingBlock:^(NSHTTPCookie * _Nonnull obj, NSUInteger idx, BOOL * _Nonnull stop) { - MVMCoreLog(@"Cookie Name: %@, Cookie Value: %@",obj.name, obj.value); + [[[NSHTTPCookieStorage sharedHTTPCookieStorage] cookiesForURL:request.URL] enumerateObjectsUsingBlock:^(NSHTTPCookie * _Nonnull obj, NSUInteger idx, BOOL * _Nonnull stop) { + MVMCoreLog(@"Cookie Name: %@, Cookie Value: %@, Domain: %@", obj.name, obj.value, obj.domain); }]; [[NSNotificationCenter defaultCenter] postNotificationName:MVMCoreNotificationGoingToServer object:nil];