mbrucedogs/mvm_core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

saftey against handler implementtations

Browse Source
This commit is contained in:
Kyle Matthew Hedden 2022-04-25 17:15:12 -04:00
parent fa43578968
commit e19ed416bb
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
MVMCore/MVMCore/Models/ActionType/Client Parameters/ClientParameterHandler.swift
View File

@ -88,19 +88,31 @@
complete = true
}
}
guard self.parameterHandlerList.count > 0 else {
completionHandler(nil)
return
}
// Setup timeout.
self.parametersWorkQueue.asyncAfter(deadline: .now() + .seconds(Int(timeout)), execute: timeoutWorkItem)
self.group.enter()
// Setup the parameter execution.
for (index, parameterHandler) in self.parameterHandlerList.enumerated() {
self.group.enter()
let parameterType = parameterHandler.clientParameterModel.type
parameterHandler.fetchClientParameters(requestParameters: requestParameters,
timingOutIn: timeout) { (receivedParameter) in
// Queue the results for merge.
self.parametersWorkQueue.async {
if (returnedList[index] != nil) {
MVMCoreLoggingHandler.shared()?.addError(toLog: MVMCoreErrorObject(title: nil, message: "Client parameter \(parameterType) has already executed. The completion handler should only be called once!", code: ErrorCode.default.rawValue, domain: ErrorDomainNative, location: String(describing: ClientParameterHandler.self))!)
}
returnedList[index] = receivedParameter
self.group.leave() // Leaving is only done after setup (barriered).
if (returnedList.allSatisfy { $0 != nil }) {
self.group.leave() // Leaving is only done after setup (barriered).
}
}
}
}