From de10ed8eef3449ff66ba2aa826fbbe9c90a2e34d Mon Sep 17 00:00:00 2001 From: "Suresh, Kamlesh" Date: Thu, 11 Mar 2021 15:32:20 -0500 Subject: [PATCH] comment --- .../ActionType/Client Parameters/ClientParameterHandler.swift | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MVMCore/MVMCore/Models/ActionType/Client Parameters/ClientParameterHandler.swift b/MVMCore/MVMCore/Models/ActionType/Client Parameters/ClientParameterHandler.swift index 1fd35d0..1fb9cf3 100644 --- a/MVMCore/MVMCore/Models/ActionType/Client Parameters/ClientParameterHandler.swift +++ b/MVMCore/MVMCore/Models/ActionType/Client Parameters/ClientParameterHandler.swift @@ -50,6 +50,8 @@ import Foundation // Dispatch setup on queue to ensure setup is complete before completion callbacks. + + // Don't use [weak self]. Object is deallocated in the dispatch queue. parametersWorkQueue.async(group: group, qos: .userInitiated) { // Create the handler list so that same object can be used when merging. Merging needs default value in case of timeout for parameterModel in clientParameterModel.list { @@ -72,7 +74,6 @@ import Foundation // Setup completion handlers. Barriered to ensure one happens after the other. var complete = false let timeoutWorkItem = DispatchWorkItem(qos: .userInitiated) { - // Holding self. so that its not deallocated in the deispatch queue completionHandler(mergedParametersList); complete = true }