From 7006ea83dfd3842e6a3acc76ca734f3059585643 Mon Sep 17 00:00:00 2001
From: "Suresh, Kamlesh" <kamlesh.suresh@verizonwireless.com>
Date: Thu, 4 Mar 2021 14:17:20 -0500
Subject: [PATCH] fix

---
 .../ActionHandling/MVMCoreActionHandler.h      |  2 +-
 .../ActionHandling/MVMCoreActionHandler.m      | 18 ++++++------------
 2 files changed, 7 insertions(+), 13 deletions(-)

diff --git a/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.h b/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.h
index 6e272d4..616eb03 100644
--- a/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.h
+++ b/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.h
@@ -32,7 +32,7 @@ extern NSString * _Nonnull const KeyActionTypeOpen;
 - (void)synchronouslyHandleAction:(nullable NSString *)actionType actionInformation:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
 ///  Iterates through the clientParameters list. Gets values from the individual handlers and attaches the parameters to extraParameters.
-- (void)setClientParameter:(nullable NSDictionary *)clientParametersMap requestParameters:(nullable NSDictionary *)requestParameters isBackgroudRequest:(BOOL)isBackgroudRequest completionHandler:(nonnull void (^)(NSDictionary * _Nullable jsonDictionary))completionHandler;
+- (void)getClientParameter:(nullable NSDictionary *)clientParametersMap requestParameters:(nullable NSDictionary *)requestParameters showLoadingOverlay:(BOOL)showLoadingOverlay completionHandler:(nonnull void (^)(NSDictionary * _Nullable jsonDictionary))completionHandler;
 
 #pragma mark - Actions
 /// by default, returns the original RequestParameter that passed in. Can be overriden for some generic updates to the RequestParameter before handle open page action gets called.
diff --git a/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.m b/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.m
index 437faae..285b522 100644
--- a/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.m
+++ b/MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.m
@@ -93,7 +93,7 @@ NSString * const KeyActionTypeOpen = @"openPage";
     }
 }
 
-- (void)setClientParameter:(nullable NSDictionary *)clientParametersMap requestParameters:(nullable NSDictionary *)requestParameters showLoadingOverlay:(BOOL)showLoadingOverlay completionHandler:(nonnull void (^)(NSDictionary * _Nullable extraParameters))completionHandler {
+- (void)getClientParameter:(nullable NSDictionary *)clientParametersMap requestParameters:(nullable NSDictionary *)requestParameters showLoadingOverlay:(BOOL)showLoadingOverlay completionHandler:(nonnull void (^)(NSDictionary * _Nullable parameters))completionHandler {
     
     if (!clientParametersMap) {
         completionHandler(nil);
@@ -355,7 +355,7 @@ NSString * const KeyActionTypeOpen = @"openPage";
         [weakSelf prepareLinkAwayWithURL:otherURL appURL:appURL actionInformation:actionWithClientParameters additionalData:additionalData delegateObject:delegateObject];
     };
 
-    [self setClientParameter:[actionInformation dict:KeyClientParameters]
+    [self getClientParameter:[actionInformation dict:KeyClientParameters]
            requestParameters:nil
           showLoadingOverlay:true
            completionHandler:performAction];
@@ -417,23 +417,17 @@ NSString * const KeyActionTypeOpen = @"openPage";
     // Currently no default log action but this will eventually be server driven.
 }
 
-+ (void)defaultHandleOpenPageForRequestParameters:(nonnull MVMCoreRequestParameters *)requestParameters additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject {
-    //
-
-    void (^performRequest)(MVMCoreRequestParameters*) = ^(MVMCoreRequestParameters* requestParametersB) {
-        [[MVMCoreLoadHandler sharedGlobal] loadRequest:requestParametersB dataForPage:additionalData delegateObject:delegateObject];
-    };
-
++ (void)defaultHandleOpenPageForRequestParameters:(nonnull MVMCoreRequestParameters *)requestParameters additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject {    
     if (requestParameters.clientParamters) {
-        [[MVMCoreActionHandler sharedActionHandler] setClientParameter:requestParameters.clientParamters
+        [[MVMCoreActionHandler sharedActionHandler] getClientParameter:requestParameters.clientParamters
                requestParameters: requestParameters.parameters
              showLoadingOverlay: !requestParameters.backgroundRequest
             completionHandler: ^(NSDictionary * _Nullable jsonDictionary) {
             [requestParameters addRequestParameters:jsonDictionary];
-            performRequest(requestParameters);
+            [[MVMCoreLoadHandler sharedGlobal] loadRequest:requestParameters dataForPage:additionalData delegateObject:delegateObject];
         }];
     } else {
-        performRequest(requestParameters);
+        [[MVMCoreLoadHandler sharedGlobal] loadRequest:requestParameters dataForPage:additionalData delegateObject:delegateObject];
     }
 }