review comments

MVMCore/MVMCore/ActionHandling/MVMCoreActionDelegateProtocol+Extension.swift

@@ -9,7 +9,7 @@
 import Foundation
 
 public extension MVMCoreActionDelegateProtocol {
-    // Handles any action errors.
+    /// Handles any action errors.
     func handleAction(error: MVMCoreErrorObject, action: ActionModelProtocol, additionalData: [AnyHashable: Any]?) {
         MVMCoreActionHandler.shared()?.defaultHandleActionError(error, additionalData: additionalData)
     }

MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler+Extension.swift

@@ -19,8 +19,9 @@ public extension MVMCoreActionHandler {
             }
             return json
         } catch {
-            let errorObject = MVMCoreErrorObject.createErrorObject(for: error, location: "")!
-            delegateObject?.actionDelegate?.handleAction(error: errorObject, action: model, additionalData: model.extraParameters) ?? MVMCoreActionHandler.shared()?.defaultHandleActionError(errorObject, additionalData: model.extraParameters)
+            if let errorObject = MVMCoreErrorObject.createErrorObject(for: error, location: "") {
+                delegateObject?.actionDelegate?.handleAction(error: errorObject, action: model, additionalData: model.extraParameters) ?? MVMCoreActionHandler.shared()?.defaultHandleActionError(errorObject, additionalData: model.extraParameters)
+            }
             return nil
         }
     }

MVMCore/MVMCore/ActionHandling/MVMCoreActionHandler.h

@@ -19,92 +19,92 @@ extern NSString * _Nonnull const KeyActionTypeOpen;
 
 @interface MVMCoreActionHandler : NSObject
 
-// Returns the shared action handler
+/// Returns the shared action handler
 + (nullable instancetype)sharedActionHandler;
 
-// Convenience function for handling actions. This will pull action and pageInfo out of the dictionary and call handleAction: actionInformation: with those values
+/// Convenience function for handling actions. This will pull action and pageInfo out of the dictionary and call handleAction: actionInformation: with those values
 - (void)handleActionWithDictionary:(nullable NSDictionary *)dictionary additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Asynchronously handles action (dispatches and calls below function). Used by server driven user actions..
+/// Asynchronously handles action (dispatches and calls below function). Used by server driven user actions..
 - (void)handleAction:(nullable NSString *)actionType actionInformation:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Synchronously handles action. Used by server driven user actions..
+/// Synchronously handles action. Used by server driven user actions..
 - (void)synchronouslyHandleAction:(nullable NSString *)actionType actionInformation:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
 #pragma mark - Actions
-// by default, returns the original RequestParameter that passed in. Can be overriden for some generic updates to the RequestParameter before handle open page action gets called. 
+/// by default, returns the original RequestParameter that passed in. Can be overriden for some generic updates to the RequestParameter before handle open page action gets called.
 - (void)updateRequestParametersBeforeHandleOpenPageAction:(nonnull MVMCoreRequestParameters *)requestParameters callBack:(void (^_Nonnull)(MVMCoreRequestParameters * _Nonnull requestParameters))callback;
 
-// Logs the action. Currently is not action information driven... depends on delegate.
+/// Logs the action. Currently is not action information driven... depends on delegate.
 - (void)logAction:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Tries to open a page
+/// Tries to open a page
 - (void)openPageAction:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// restarts the app
+/// restarts the app
 - (void)restartAction:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Goes back
+/// Goes back
 - (void)backAction:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Makes a phone call
+/// Makes a phone call
 - (void)callAction:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Makes the previous request, needs the delegate for this
+/// Makes the previous request, needs the delegate for this
 - (void)previousSubmitAction:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Redirects to another experience
+/// Redirects to another experience
 - (void)redirectAction:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Cancels (like in a popup)
+/// Cancels (like in a popup)
 - (void)cancelAction:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Goes to settings app
+/// Goes to settings app
 - (void)settingsAction:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
 /// Performs multiple actions
 - (void)actions:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Subclass this to handle other custom actions. Return YES if handled, and NO if not.
+/// Subclass this to handle other custom actions. Return YES if handled, and NO if not.
 - (BOOL)handleOtherActions:(nullable NSString *)actionType actionInformation:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Last chance to handle unknown actions before throwing an error
+/// Last chance to handle unknown actions before throwing an error
 - (void)unknownAction:(nullable NSString *)actionType actionInformation:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Handles action errors.
+/// Handles action errors.
 - (void)handleActionError:(nullable MVMCoreErrorObject *)error actionInformation:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
 #pragma mark - Link away action
 
-// Links away to app or browser
+/// Links away to app or browser
 - (void)linkAwayAction:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Can subclass to add to urls if needed at global level (delegate is also called)
+/// Can subclass to add to urls if needed at global level (delegate is also called)
 - (void)prepareLinkAwayWithURL:(nullable NSURL *)url appURL:(nullable NSURL *)appURL actionInformation:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Opens the url
+/// Opens the url
 - (void)openURL:(nullable NSURL *)url appURL:(nullable NSURL *)appURL actionInformation:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// opens the url in a webview.
+/// opens the url in a webview.
 - (void)openURLInWebView:(nullable NSURL *)url actionInformation:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
 #pragma mark - Default Action Protocol Functions
 
-// Currently no default log action but this will eventually be server driven.
+/// Currently no default log action but this will eventually be server driven.
 + (void)defaultLogAction:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Sends the request to the load handler.
+/// Sends the request to the load handler.
 + (void)defaultHandleOpenPageForRequestParameters:(nonnull MVMCoreRequestParameters *)requestParameters additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// By default, throws an error, calling defaultHandleActionError.
+/// By default, throws an error, calling defaultHandleActionError.
 + (void)defaultHandleUnknownActionType:(nullable NSString *)actionType actionInformation:(nullable NSDictionary *)actionInformation additionalData:(nullable NSDictionary *)additionalData delegateObject:(nullable DelegateObject *)delegateObject;
 
-// Logs the error.
+/// Logs the error.
 - (void)defaultHandleActionError:(nonnull MVMCoreErrorObject *)error additionalData:(nullable NSDictionary *)additionalData;
 
 #pragma mark - Deprecated
 
-// Convenience function for handling actions. This will pull action and pageInfo out of the dictionary and call handleAction: actionInformation: with those values
+/// Convenience function for handling actions. This will pull action and pageInfo out of the dictionary and call handleAction: actionInformation: with those values
 - (void)handleActionWithDictionary:(nullable NSDictionary *)dictionary additionalData:(nullable NSDictionary *)additionalData delegate:(nullable NSObject <MVMCoreLoadDelegateProtocol,MVMCorePresentationDelegateProtocol,MVMCoreActionDelegateProtocol>*)delegate __deprecated;
 
 @end