mbrucedogs/mvm_core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Digital PCT265 story MVAPCT-48 - Bug fixes and optimizations

Browse Source
This commit is contained in:
Scott Pfeil 2024-04-03 21:49:19 -04:00
parent 25b79530eb
commit 64aba6a100
4 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
MVMCore/MVMCore/ActionHandling/ActionOpenPageHandler.swift
View File

@ -83,7 +83,7 @@ open class ActionOpenPageHandler: MVMCoreJSONActionHandlerProtocol {
} }
// Adds any client parameters to the request parameters. // Adds any client parameters to the request parameters.
if let parametersToFetch = model.clientParameters, if let parametersToFetch = model.clientParameters,
let fetchedParameters = try await ClientParameterHandler().getClientParameters( let fetchedParameters = await ClientParameterHandler().getClientParameters(
with: parametersToFetch, with: parametersToFetch,
requestParameters: requestParameters.parameters as? [String : Any] ?? [:], requestParameters: requestParameters.parameters as? [String : Any] ?? [:],
actionId: MVMCoreActionHandler.getUUID(additionalData: additionalData) ?? "unknown", actionId: MVMCoreActionHandler.getUUID(additionalData: additionalData) ?? "unknown",

1
MVMCore/MVMCore/LoadHandling/MVMCoreLoadRequestOperation+Extension.swift
View File

@ -69,6 +69,7 @@ public extension MVMCoreLoadRequestOperation {
return nil return nil
} }
MVMCoreLoggingHandler.logDebugMessage(withDelegate: "\(type(of: self)): Navigated to controller. pageType:\(pageType) controllerType:\(String(describing: controllerType))") MVMCoreLoggingHandler.logDebugMessage(withDelegate: "\(type(of: self)): Navigated to controller. pageType:\(pageType) controllerType:\(String(describing: controllerType))")
stopLoadingAnimationIfNeeded()
return viewController return viewController
} }

1
MVMCore/MVMCore/LoadHandling/MVMCoreLoadRequestOperation.h
View File

@ -19,7 +19,6 @@
@interface MVMCoreLoadRequestOperation : MVMCoreOperation @interface MVMCoreLoadRequestOperation : MVMCoreOperation
@property (nullable, strong, nonatomic) MVMCoreRequestParameters *requestParameters; @property (nullable, strong, nonatomic) MVMCoreRequestParameters *requestParameters;
/// For load objects as in input parameter. Does not attach self generated load objects.
@property (nullable, strong, nonatomic) MVMCoreLoadObject *loadObject; @property (nullable, strong, nonatomic) MVMCoreLoadObject *loadObject;
@property (nullable, strong, nonatomic) NSDictionary *dataForPage; @property (nullable, strong, nonatomic) NSDictionary *dataForPage;
@property (nullable, strong, nonatomic) DelegateObject *delegateObject; @property (nullable, strong, nonatomic) DelegateObject *delegateObject;

1
MVMCore/MVMCore/LoadHandling/MVMCoreLoadRequestOperation.m
View File

@ -147,6 +147,7 @@
// Create a load object from any data we fetched. // Create a load object from any data we fetched.
MVMCoreLoadObject *loadObject = [self createLoadObjectWithPageFromCache:pageFromCache modulesFromCache:modulesFromCache]; MVMCoreLoadObject *loadObject = [self createLoadObjectWithPageFromCache:pageFromCache modulesFromCache:modulesFromCache];
self.loadObject = loadObject;
// Check if we need to go to server for missing data. // Check if we need to go to server for missing data.
MVMCoreRequestParameters *requestForMissingData = [MVMCoreLoadRequestOperation createRequestForDataWithLoadObject:loadObject]; MVMCoreRequestParameters *requestForMissingData = [MVMCoreLoadRequestOperation createRequestForDataWithLoadObject:loadObject];