mbrucedogs/mvm_core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'bugfix/request_signature_nullability' into 'develop'

Browse Source 
fix nullability for request creation. don't force a default error to be passed in

### Summary
Request signature fix. Related to error logging Swift conversion.

### JIRA Ticket
https://onejira.verizon.com/browse/ONEAPP-5203

See merge request https://gitlab.verizon.com/BPHV_MIPS/mvm_core/-/merge_requests/273
This commit is contained in:
Hedden, Kyle Matthew 2023-07-28 14:32:14 +00:00
commit 5493c32682
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
MVMCore/MVMCore/LoadHandling/MVMCoreLoadHandler.h
View File

@ -51,7 +51,7 @@
- (nonnull NSDictionary *)convertToJsonDictionary:(nonnull MVMCoreRequestParameters *)requestParameters;
// Creates a request object with the given parameters.
- (nullable NSURLRequest *)requestWithParameters:(nonnull MVMCoreRequestParameters *)requestParameters error:(MVMCoreErrorObject *_Nonnull *_Nonnull)error;
- (nullable NSURLRequest *)requestWithParameters:(nonnull MVMCoreRequestParameters *)requestParameters error:(MVMCoreErrorObject *_Nullable *_Nonnull)error;
// Sends a given request to the server. When it is finished, it calls request finished, passing along the json object or nil if there is an error.
- (nullable NSURLSessionTask *)sendRequest:(nonnull MVMCoreRequestParameters *)requestParameters locationForError:(nonnull NSString *)locationForError requestFinished:(nullable void (^)(id _Nullable jsonObject, MVMCoreErrorObject * _Nullable error))requestFinished;

2
MVMCore/MVMCore/LoadHandling/MVMCoreLoadHandler.m
View File

@ -133,7 +133,7 @@
#pragma mark - Request Functions.
- (nullable NSURLRequest *)requestWithParameters:(nonnull MVMCoreRequestParameters *)requestParameters error:(MVMCoreErrorObject *_Nonnull *_Nonnull)error {
- (nullable NSURLRequest *)requestWithParameters:(nonnull MVMCoreRequestParameters *)requestParameters error:(MVMCoreErrorObject *_Nullable *_Nonnull)error {
NSURL *url = [requestParameters resolveURL:[MVMCoreSessionObject sharedGlobal]];