From 12d17dbca8fdf148f1d2d42f3bb15e67021850bb Mon Sep 17 00:00:00 2001 From: "Hedden, Kyle Matthew" Date: Fri, 4 Oct 2024 12:20:35 -0400 Subject: [PATCH 1/2] Digital PCT265 defect MVAPCT-322: Convert couple more hard coded restarts to be soft. --- MVMCore/MVMCore/OtherHandlers/MVMCoreLoggingHandler.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MVMCore/MVMCore/OtherHandlers/MVMCoreLoggingHandler.swift b/MVMCore/MVMCore/OtherHandlers/MVMCoreLoggingHandler.swift index c23b113..660c1f9 100644 --- a/MVMCore/MVMCore/OtherHandlers/MVMCoreLoggingHandler.swift +++ b/MVMCore/MVMCore/OtherHandlers/MVMCoreLoggingHandler.swift @@ -95,7 +95,7 @@ import os @objc(addErrorToLog:) open func addError(toLog errorObject: MVMCoreErrorObject) { if errorObject.silentError { - handleWarningMessage(errorObject.messageToLog ?? errorObject.messageToDisplay ?? "Some error occrured.", category: "Handled Exception") + handleWarningMessage(errorObject.messageToLog ?? errorObject.messageToDisplay ?? "Some error occurred.", category: "Handled Exception") } else { handleErrorMessage(errorObject.messageToLog ?? errorObject.messageToDisplay ?? "Some error occurred.", category: "Handled Exception") } From 8f2483eb1b25d4241f567d96995a025e30f6c518 Mon Sep 17 00:00:00 2001 From: "Hedden, Kyle Matthew" Date: Fri, 4 Oct 2024 12:20:59 -0400 Subject: [PATCH 2/2] Digital PCT265 defect MVAPCT-322: Mesasge to log for modules missing their ResponseInfo. --- .../MVMCore/LoadHandling/MVMCoreLoadRequestOperation.m | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/MVMCore/MVMCore/LoadHandling/MVMCoreLoadRequestOperation.m b/MVMCore/MVMCore/LoadHandling/MVMCoreLoadRequestOperation.m index 0afeeba..172dd8b 100644 --- a/MVMCore/MVMCore/LoadHandling/MVMCoreLoadRequestOperation.m +++ b/MVMCore/MVMCore/LoadHandling/MVMCoreLoadRequestOperation.m @@ -688,7 +688,13 @@ NSDictionary *responseInfo = [obj dict:KeyResponseInfo]; //Response Info is missing but errorObject should be created with generic message + code + domain if (responseInfo == nil) { - errorObject = [[MVMCoreLoadHandler sharedGlobal] errorForLoadObject:loadObject withTitle:nil message:[MVMCoreGetterUtility hardcodedStringWithKey:HardcodedErrorCritical] code:ErrorCodeJSONNotDictionary domain:ErrorDomainServer]; + errorObject = [[MVMCoreLoadHandler sharedGlobal] + errorForLoadObject:loadObject + withTitle:nil + message:[MVMCoreGetterUtility hardcodedStringWithKey:HardcodedErrorCritical] + messageToLog:[NSString stringWithFormat:@"Module %@ is missing a %@ object.", key, KeyResponseInfo] + code:ErrorCodeJSONNotDictionary + domain:ErrorDomainServer]; } else if (![ValueTypeSuccess isEqualToString:[responseInfo string:KeyType]]) { errorObject = [[MVMCoreLoadHandler sharedGlobal] attachLoadInformation:loadObject toError: [[MVMCoreErrorObject alloc]