mbrucedogs/mvm_core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

adding more logs to understand the point of failure

Browse Source
This commit is contained in:
Khan, Arshad 2021-08-03 16:02:48 +05:30
parent b3c0673c83
commit 2c9e394347
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
MVMCore/MVMCore/LoadHandling/MVMCoreLoadRequestOperation.m
View File

@ -408,6 +408,7 @@
// Handle any module caching error and continue load.
if (moduleCachingError) {
MVMCoreLog(@"possible point 1 for no page error");
[MVMCoreLoadRequestOperation handleError:moduleCachingError loadObject:loadObject showAlertForErrorIfApplicable:YES];
}
@ -423,6 +424,7 @@
// Handle any page caching error and continue load.
if (pagesCachingError) {
MVMCoreLog(@"possible point 2 for no page error");
[MVMCoreLoadRequestOperation handleError:pagesCachingError loadObject:loadObject showAlertForErrorIfApplicable:YES];
}
@ -434,6 +436,7 @@
[MVMCoreLoadRequestOperation notifyListenersOfNewResponse:pages modules:modules systemParameters:systemParameters loadObject:loadObject];
} continueBlock:^{
if (error) {
MVMCoreLog(@"possible point 3 for no page error");
// Hold onto any error until we establish a delegate
[MVMCoreLoadRequestOperation handleError:error loadObject:loadObject showAlertForErrorIfApplicable:NO];
loadObject.operation.alertToShow = YES;
@ -753,7 +756,7 @@
MVMCoreLog(@"Error: %@ %@ %@ %@ %@",[error stringErrorCode], error.domain, error.location,error.messageToDisplay, error.messageToLog);
if (showAlertForErrorIfApplicable && (!loadObject.operation.backgroundLoad || loadObject.requestParameters.allowAlertsIfBackgroundRequest) && !loadObject.requestParameters.handleErrorsSilently && !error.silentError && !error.errorScreenError) {
MVMCoreLog(@"last point for no page error");
// Show alert for error.
[MVMCoreLoadRequestOperation createAndShowAlertForLoadObject:loadObject error:error delegateObject:loadObject.operation.delegateObject];
}
@ -773,9 +776,11 @@
// Native driven error screens still need to be loaded. (as long as the delegate desires)
if (!loadObject.requestParameters.handleErrorsSilently && !error.silentError && error.errorScreenError && (![loadObject.delegateObject.loadDelegate respondsToSelector:@selector(shouldContinueToErrorPage:error:)] || [loadObject.delegateObject.loadDelegate shouldContinueToErrorPage:loadObject error:error])) {
MVMCoreLog(@"possible point 4 for no page error");
[MVMCoreLoadRequestOperation handleError:error loadObject:loadObject showAlertForErrorIfApplicable:YES];
[MVMCoreLoadRequestOperation handleLoadObject:loadObject error:error];
} else {
MVMCoreLog(@"possible point 5 for no page error");
[MVMCoreLoadRequestOperation handleError:error loadObject:loadObject showAlertForErrorIfApplicable:YES];
[MVMCoreLoadRequestOperation loadFinished:loadObject loadedViewController:nil errorObject:error];
}