mbrucedogs/mvm_core
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Potential Fix for Crash

Browse Source
This commit is contained in:
Danish Phiroz 2024-10-01 16:08:55 -04:00
parent a570f3c0e6
commit 2b36711bca
2 changed files with 27 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
MVMCore/MVMCore/LoadHandling/MVMCoreLoadRequestOperation.m
View File

@ -686,17 +686,20 @@
if (obj && [obj isKindOfClass:[NSDictionary class]]) { if (obj && [obj isKindOfClass:[NSDictionary class]]) {
NSDictionary *responseInfo = [obj dict:KeyResponseInfo]; NSDictionary *responseInfo = [obj dict:KeyResponseInfo];
if (![ValueTypeSuccess isEqualToString:[responseInfo string:KeyType]]) { if (responseInfo == nil) {
errorObject = [[MVMCoreLoadHandler sharedGlobal] attachLoadInformation:loadObject toError: errorObject = [[MVMCoreLoadHandler sharedGlobal] errorForLoadObject:loadObject withTitle:nil message:[MVMCoreGetterUtility hardcodedStringWithKey:HardcodedErrorCritical] code:ErrorCodeJSONNotDictionary domain:ErrorDomainSystem];
[[MVMCoreErrorObject alloc] }else {
initWithTitle:[responseInfo stringForKey:KeyErrorHeading] if (![ValueTypeSuccess isEqualToString:[responseInfo string:KeyType]]) {
message:[responseInfo stringForKey:KeyUserMessage] errorObject = [[MVMCoreLoadHandler sharedGlobal] attachLoadInformation:loadObject toError:
messageToLog:[responseInfo stringForKey:KeyMessage] [[MVMCoreErrorObject alloc]
code:[[responseInfo string:KeyCode] integerValue] initWithTitle:[responseInfo stringForKey:KeyErrorHeading]
domain:ErrorDomainServer message:[responseInfo stringForKey:KeyUserMessage]
location:[[MVMCoreLoadHandler sharedGlobal] errorLocationForRequest:loadObject]]]; messageToLog:[responseInfo stringForKey:KeyMessage]
code:[[responseInfo string:KeyCode] integerValue]
domain:ErrorDomainServer
location:[[MVMCoreLoadHandler sharedGlobal] errorLocationForRequest:loadObject]]];
}
} }
// Caches each dictionary from the array. // Caches each dictionary from the array.
[[MVMCoreCache sharedCache] addModuleToCache:obj module:key queue:nil waitUntilFinished:YES completionBlock:NULL]; [[MVMCoreCache sharedCache] addModuleToCache:obj module:key queue:nil waitUntilFinished:YES completionBlock:NULL];
} else { } else {

14
MVMCore/MVMCore/Utility/MVMCoreErrorObject.m
View File

@ -23,8 +23,10 @@
// Initialization code // Initialization code
self.title = title; self.title = title;
self.messageToDisplay = message; self.messageToDisplay = message;
self.messageToLog = message;
self.code = code; self.code = code;
self.domain = domain; self.domain = domain;
self.systemDomain = nil;
self.location = location; self.location = location;
self.date = [NSDate date]; self.date = [NSDate date];
self.silentError = YES; self.silentError = YES;
@ -32,6 +34,11 @@
[MVMCoreDispatchUtility performSyncBlockOnMainThread:^{ [MVMCoreDispatchUtility performSyncBlockOnMainThread:^{
self.applicationState = [UIApplication sharedApplication].applicationState; self.applicationState = [UIApplication sharedApplication].applicationState;
}]; }];
self.sessionId = nil;
self.requestId = nil;
self.requestUrl = nil;
self.serverResponseInfo = nil;
self.crashLog = nil;
} }
return self; return self;
} }
@ -41,9 +48,11 @@
if (self = [super init]) { if (self = [super init]) {
// Initialization code // Initialization code
self.title = title; self.title = title;
self.messageToDisplay = nil;
self.messageToLog = messageToLog; self.messageToLog = messageToLog;
self.code = code; self.code = code;
self.domain = domain; self.domain = domain;
self.systemDomain = nil;
self.location = location; self.location = location;
self.date = [NSDate date]; self.date = [NSDate date];
self.silentError = YES; self.silentError = YES;
@ -51,6 +60,11 @@
[MVMCoreDispatchUtility performSyncBlockOnMainThread:^{ [MVMCoreDispatchUtility performSyncBlockOnMainThread:^{
self.applicationState = [UIApplication sharedApplication].applicationState; self.applicationState = [UIApplication sharedApplication].applicationState;
}]; }];
self.sessionId = nil;
self.requestId = nil;
self.requestUrl = nil;
self.serverResponseInfo = nil;
self.crashLog = nil;
} }
return self; return self;
} }