Address code review comment of piping data for page.
This commit is contained in:
parent
d394bbea0e
commit
1e487dd58b
@ -36,7 +36,7 @@ open class ActionOpenPageHandler: MVMCoreJSONActionHandlerProtocol {
|
|||||||
}
|
}
|
||||||
|
|
||||||
if operation.error != nil, let fallbackResponseJson = model.fallbackResponse?.toJSON() {
|
if operation.error != nil, let fallbackResponseJson = model.fallbackResponse?.toJSON() {
|
||||||
await runFallback(response: fallbackResponseJson, requestParameters: requestParameters, delegateObject: delegateObject)
|
await runFallback(response: fallbackResponseJson, requestParameters: requestParameters, delegateObject: delegateObject, additionalData: additionalData)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
} catch {
|
} catch {
|
||||||
@ -45,8 +45,8 @@ open class ActionOpenPageHandler: MVMCoreJSONActionHandlerProtocol {
|
|||||||
}
|
}
|
||||||
|
|
||||||
/// Given backup JSON data, run it through the load handler.
|
/// Given backup JSON data, run it through the load handler.
|
||||||
fileprivate func runFallback(response: JSONDictionary, requestParameters: MVMCoreRequestParameters, delegateObject: DelegateObject?) async {
|
fileprivate func runFallback(response: JSONDictionary, requestParameters: MVMCoreRequestParameters, delegateObject: DelegateObject?, additionalData: [AnyHashable : Any]?) async {
|
||||||
guard let loadHandler = MVMCoreLoadHandler.sharedGlobal(), let fallbackLoadObject = MVMCoreLoadObject(requestParameters: requestParameters, dataForPage: nil, delegateObject: delegateObject)
|
guard let loadHandler = MVMCoreLoadHandler.sharedGlobal(), let fallbackLoadObject = MVMCoreLoadObject(requestParameters: requestParameters, dataForPage: additionalData, delegateObject: delegateObject)
|
||||||
else { return }
|
else { return }
|
||||||
|
|
||||||
let (loadObject, errorObject) = await MVMCoreLoadRequestOperation.processJSON(fromServer: response, loadObject: fallbackLoadObject)
|
let (loadObject, errorObject) = await MVMCoreLoadRequestOperation.processJSON(fromServer: response, loadObject: fallbackLoadObject)
|
||||||
|
|||||||
Loading…
Reference in New Issue
Block a user