From 161cc0132d6e98fc15bf32ab233d1907f930efe8 Mon Sep 17 00:00:00 2001 From: mayur nilwant Date: Fri, 14 Jun 2024 00:11:02 -0400 Subject: [PATCH] Removed check for pageType for App level , making it generic on cachePolicy. --- MVMCore/MVMCore/OtherHandlers/MVMCoreCache+Extension.swift | 1 - MVMCore/MVMCore/OtherHandlers/MVMCoreCache.h | 2 +- MVMCore/MVMCore/OtherHandlers/MVMCoreCache.m | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/MVMCore/MVMCore/OtherHandlers/MVMCoreCache+Extension.swift b/MVMCore/MVMCore/OtherHandlers/MVMCoreCache+Extension.swift index b7f1f21..23ec96b 100644 --- a/MVMCore/MVMCore/OtherHandlers/MVMCoreCache+Extension.swift +++ b/MVMCore/MVMCore/OtherHandlers/MVMCoreCache+Extension.swift @@ -141,7 +141,6 @@ extension PersistentCacheManager { guard let cachePolicy = infoDictionary[KeyCachePolicy] as? Dictionary, let appLevelKey = cachePolicy[KeyAppLevelCachePolicy] as? Bool, appLevelKey == true, - self.shouldCachePageJSON(infoDictionary, pageType: PageTypeOfflineFeedback) == true, self.isJSONExpired(infoDictionary) == false else {return false} return true } diff --git a/MVMCore/MVMCore/OtherHandlers/MVMCoreCache.h b/MVMCore/MVMCore/OtherHandlers/MVMCoreCache.h index 84dcb5d..8e1ca57 100644 --- a/MVMCore/MVMCore/OtherHandlers/MVMCoreCache.h +++ b/MVMCore/MVMCore/OtherHandlers/MVMCoreCache.h @@ -15,7 +15,7 @@ extern NSString * _Nonnull const KeyCachePolicy; extern NSString * _Nonnull const KeyCacheExpiry; extern NSString * _Nonnull const KeyAppLevelCachePolicy; -extern NSString * _Nonnull const PageTypeOfflineFeedback; + //block returned when getting image diff --git a/MVMCore/MVMCore/OtherHandlers/MVMCoreCache.m b/MVMCore/MVMCore/OtherHandlers/MVMCoreCache.m index a24b548..9bc6c0a 100644 --- a/MVMCore/MVMCore/OtherHandlers/MVMCoreCache.m +++ b/MVMCore/MVMCore/OtherHandlers/MVMCoreCache.m @@ -20,7 +20,7 @@ NSString * _Nonnull const KeyCachePolicy = @"cachePolicy"; NSString * _Nonnull const KeyCacheExpiry = @"expiry"; NSString * _Nonnull const KeyAppLevelCachePolicy = @"applicationLevelCache"; -NSString * _Nonnull const PageTypeOfflineFeedback = @"offlineFeedback"; + @interface MVMCoreCache ()